sortedcord/omnia-consolidated
1
0
Fork 0
mirror of https://github.com/sortedcord/omnia.git synced 2026-07-22 03:52:48 +05:30
Code Issues Packages Projects Releases Wiki Activity

refactor(core): Remove re-implementations of alias resolver

Browse Source
This commit is contained in:
Aditya Gupta
2026-07-11 17:28:54 +05:30
parent 224553c98c
commit 99c11cbbfe
7 changed files with 29 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/core/src/alias.ts Normal file
View File

@@ -0,0 +1,6 @@
import { Entity } from "./entity.js";
export function resolveAlias(viewer: Entity, targetId: string): string {
if (targetId === viewer.id) return "you";
return viewer.aliases.get(targetId) ?? "an unfamiliar figure";
}

8
packages/core/src/index.ts
View File

@@ -1,5 +1,13 @@
/**
* Monorepo Hygiene Note:
* If a pure function only touches types owned by core (e.g., Entity, WorldState, Attribute),
* it belongs here in the core package (e.g., in a dedicated file like alias.ts), even if
* a higher-level package is currently its only consumer.
*/
export * from "./attribute.js";
export * from "./entity.js";
export * from "./world.js";
export * from "./clock.js";
export * from "./repository.js";
export * from "./alias.js";

20
packages/core/src/world.ts
View File

@@ -1,6 +1,7 @@
import { AttributableObject, Attribute, serializeAttributes } from "./attribute.js";
import { Entity } from "./entity.js";
import { WorldClock } from "./clock.js";
import { resolveAlias } from "./alias.js";
export class WorldState extends AttributableObject {
/**
@@ -118,19 +119,6 @@ export function serializeObjectiveWorldState(worldState: WorldState): string {
return lines.join("\n");
}
/**
* Resolves how a viewer subjectively refers to a target entity.
* - Self → "you"
* - Known (in the viewer's alias map) → the subjective alias
* - Unknown → "an unfamiliar figure"
*
* Mirrors the implementation in @omnia/memory's resolveAlias, inlined here
* to avoid a circular dependency (memory depends on core).
*/
function resolveAliasViewer(viewer: Entity, targetId: string): string {
if (targetId === viewer.id) return "you";
return viewer.aliases.get(targetId) ?? "an unfamiliar figure";
}
/**
* Serializes a single attribute the way a viewer perceives it — name and
@@ -164,7 +152,7 @@ export function serializeSubjectiveWorldState(
}
const lines: string[] = [];
const viewerAlias = resolveAliasViewer(viewer, viewerId);
const viewerAlias = resolveAlias(viewer, viewerId);
// --- World attributes (only those the viewer can see) ---
const worldVisible = worldState.getVisibleAttributesFor(viewerId);
@@ -208,7 +196,7 @@ export function serializeSubjectiveWorldState(
if (coLocated.length > 0) {
lines.push(" Entities present with you:");
for (const e of coLocated) {
const alias = resolveAliasViewer(viewer, e.id);
const alias = resolveAlias(viewer, e.id);
lines.push(` - ${alias}:`);
const eVisible = e.getVisibleAttributesFor(viewerId);
lines.push(serializeVisibleAttributes(eVisible).split("\n").map((l) => " " + l).join("\n"));
@@ -220,7 +208,7 @@ export function serializeSubjectiveWorldState(
if (elsewhere.length > 0) {
lines.push(" Other presences you are aware of (elsewhere):");
for (const e of elsewhere) {
const alias = resolveAliasViewer(viewer, e.id);
const alias = resolveAlias(viewer, e.id);
lines.push(` - ${alias} [elsewhere]`);
}
}